Mark,
I incorporated your comments and updated the webrev.
The updated version is at:
http://dan.drydog.com/reviews/6414175-kcfconf-1/
- Dan
> adm_kef.c
> ---------
> mcp-0 lines 434-436 Since this is duplicated here and
> elsewhere, why not 'goto out' and
> free entries whose pointers are non-null?
FIXED.
> adm_kef_util.c
> --------------
> mcp-1 Thanks for adding the extra comments!
You're welcome.
>
> kcf_cryptoadm.c
> ---------------
> mcp-2 lines 85-210 What happens if a provider mentioned in
> this static table doesn't exit because the
(I assume you mean "exist", not "exit")
> administrator removed the corresponding
> loadable module?
The kcf_soft_config_init() doesn't load any modules or even depend on the
modules existing or being loaded. It just initializes soft_config_list, which
is a list of mechnisms for each default kernel software provider.
This list was previously populated from kcf.conf.
So the behavior is the same as before--the corrupted or removed provider will
still be listed by cryptoadm(1M), but it won't ever be loaded in the kernel.
Table prov_tab in kcf_prov_tabs.c is the more-important table used on module
loads/unloads.
--
This message posted from opensolaris.org
