Hi, Thanks for the patch!
On Fri, Nov 14, 2008 at 17:01:14 +0100, Christian Kellermann wrote: > since this has been biting me a couple of times already here is a > proposed 'solution'. > > This gives me > a) the chance of rereading my own crap > b) aborting when I already edit the description I'd be happy to apply this, but since it represents a (very slight) UI change, it may be prudent to see if there are any objections from our users. With this patch, doing a darcs send --edit-description will give you one last request for confirmation from darcs after you save the description and before you actually send the patch. At least 4 people so far say they have been bitten by this sort of situation, i.e. only realising that there is something that is not fit for public consumption at the moment of editing the patch bundle description. For more details, see http://bugs.darcs.net/issue1186 I am confident that we do not really need much debate on this matter, so I only plan on waiting 24 hours, 48 max. maintainer hat off ------------------ Personally, I'd give this a +1. Confirmation dialogues can be annoying, but this is a situation where no 'undo' is possible. Besides, since you are already interacting with darcs to select patches, and with your text editor to edit descriptions anyway, I don't see this creating any speed bumps in peoples' work. Note that it only affects darcs send if you use the --edit-description flag. resolve issue1186: ask before sending a bundle ---------------------------------------------- > edit_file file > return () > doc <- readDocBinFile file > + putDocLn doc > + c <- promptCharFancy "Ready to send bundle?" "yn" (Just > 'n') [] > + when ( c == 'n' ) $ do > + putStrLn $ "Ok, you don't want to send it." > + exitWith $ ExitFailure 1 -- hopefully this triggers > atexit actions? Ah I see you did not use promptYorn because you wanted a default response, in this case 'n' if you just hit Enter. Makes sense. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
