On Fri, Nov 14, 2008 at 8:28 AM, Eric Kow <[EMAIL PROTECTED]> wrote: > Hi, > > Thanks for the patch! > > On Fri, Nov 14, 2008 at 17:01:14 +0100, Christian Kellermann wrote: >> since this has been biting me a couple of times already here is a >> proposed 'solution'.
> maintainer hat off > ------------------ > Personally, I'd give this a +1. Confirmation dialogues can be annoying, > but this is a situation where no 'undo' is possible. Besides, since you > are already interacting with darcs to select patches, and with your text > editor to edit descriptions anyway, I don't see this creating any speed > bumps in peoples' work. Note that it only affects darcs send if you use > the --edit-description flag. I'm also +1 on this feature. Trent, as far as I know, is the only one that has voiced a concern with a feature like this. And his concern is quite reasonable. He said we don't want to condition the user to just hit 'y' when sending with a description. I think we should try it out for a while and plan on rolling it back or amending it if we find it's conditioning people negatively. I know I'm going to like this feature, but then my use case goes like this: 1) I have the flag for editing set in ~/.darcs 2) I start explaining the work I did and that's when it hits me I need to change something (this like the concept of rubber ducking) 3) Now I want a way out. Currently I have to kill -9 on my darcs from a different terminal to be sure the message won't go out. In all other cases, I'd be fine with the message and probably automatically hit 'y'. It's just the case where I know I'm going to hit now that I would stop to think. Assuming others operate like me, I think this change will be fine as an 'unconditional nag'. I seriously doubt people use --edit-description when running darcs from a script. For this reason, we probably don't need a way to disable the question, or do we? Okay, that's my $0.02. Thanks, Jason _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
