On Sat, Jul 07, 2007 at 12:45:45PM +0900, Daisuke Maki wrote:
>
> >Strikes me we've got a number of sql_maker overrides that are purely to
> >change the class name now, so lets factor that out.
>
> You mean like adding a DBIC::Storage::DBI->sql_maker_class() and
> providing a default DBIC::Storage::DBI->sql_maker() that instantiates
> that class?
Yeah, although (re your outline patch) I think it should be done as an
'inherited' type group accessor; that way the default can be set per-class
without having to add the _rebless hook.
> >Also, what other databases support FOR UPDATE ? Is it worth pushing that
> >one down to DBIC::SQL::Abstract itself ?
>
> Hmm, no idea, but googling for SELECT FOR UPDATE, Oracle and Mysql
> popped up. Wasn't aware of these supporting SELECT FOR UPDATE.
Interesting. I think it probably is then.
--
Matt S Trout Need help with your Catalyst or DBIx::Class project?
Technical Director Want a managed development or deployment platform?
Shadowcat Systems Ltd. Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/ http://www.shadowcatsystems.co.uk/
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/dbix-class@lists.rawmode.org/
