On Sun, Jul 08, 2007 at 12:42:52AM +0900, Daisuke Maki wrote:
>
> >Yeah, although (re your outline patch) I think it should be done as an
> >'inherited' type group accessor; that way the default can be set per-class
> >without having to add the _rebless hook.
>
> Oh, *that's* how you use this accessor system...
> grepping for 'inherited', I think I get it.
> I was wondering about that.
:)
> Okay, so I've now done the following:
> * Add sql_maker_class to DBIC::Storage::DBI as an inherited accessor
> * Change DBIC::Storage::DBI->sql_maker so that it uses
> sql_maker_class() to choose which class to instantiate
>
> * Refactored Storage::DBI::Oracle::WhereJoins's sql_maker()
> method (UNTESTED)
>
> * Add support for "locking" attribute to DBIC::SQL::Abstract
> (NOT DBIC::Storage::Pg), since we've identified Pg, mysql,
> Oracle, and DB2 supporting this syntax.
Looks fairly reasonable. Why are you calling it 'locking' instead of 'for' ?
--
Matt S Trout Need help with your Catalyst or DBIx::Class project?
Technical Director Want a managed development or deployment platform?
Shadowcat Systems Ltd. Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/ http://www.shadowcatsystems.co.uk/
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/dbix-class@lists.rawmode.org/
