Looks fairly reasonable. Why are you calling it 'locking' instead of 'for' ?
Absolutely no reason, I just used the naming used in the original post
that I based my initial changes on.
I suppose
$schema->resultset('Foo')->search(
{ ... },
{
for => 'update'
}
);
Is fair, but within DBIC::SQL::Abstract, it would still be called
'locking' or 'for_locking' or something like that, otherwise it wouldn't
make sense.
But that seems like a style matter, and in this particular context I
don't have a strong preference either way.
--d
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/dbix-class@lists.rawmode.org/
