On 2026-05-11 15:32 +0200, [email protected] wrote:
Hello,I have now addressed the points you raised and uploaded an updated package to mentors (5.0.1-2).
That's great. I have some comments (and translations) below on the details.
One thing on versioning and release practice. Some of the changes are
to the upstream part of the project (json localisation, new icons) and
are not implemented as a debian patch (and the changelog says 'New
upstream release') so that should be a change to the upstream version:
5.0.2. Debian-only changes, either to the debian packaging itself, or
patches to upstream files get counted in the -1, -2 numbering.
i.e. I think this should really be 5.0.2-1 rather than 5.0.1-2?
I can go into more detail about this if it's confusing to you.
You could call it 5.0.1-2 if there was a great big
debian/patches/json-localisation.patch and
debian/patches/free-icons.patch, and some repack machinery to remove zip,
libs_win32, dxf/{include/libdxf|src/libdxf} and include/Eigen from the
upstream release tarball.
But it probably makes way more sense to do a 5.0.2 with at least the
localisation and icon changes in. From a debian POV removing the
embedded libraries and win32-only stuff is great, but you might
want to keep them in the/a release for Windows and MacOS builds. So you
can either do two releases: e.g. a .zip with al that guff in and a much
slimmer .tgz for linux which matches what you just put in 5.0.1-2.
Or have one fat release and use the debian repack mechanisms to make a smaller
tarball.
https://wiki.debian.org/BenFinney/software/repack
has details.
There are presumably more 'git-y' ways to achieve similar effects, but I don't
know about that stuff.
Ah, I see you have done new build instructions for mac/windows people
which just tell them where to download the stuff. That looks good to
me and keeps the releases simple.
Main changes include: * switched the UI default language to English * moved translations to external JSON files to simplify localisation
Great. I had a read of en.json and it looks good. A few things below, some missed translations, some wrong translations, some grammer, a typo, some minor native adjustments "AboutText2": "<b> Standard compliance:</b>" -> "AboutText2": "<b> Standards compliance:</b>" (more than one standard is complied with and we usually to formal standards in the plural in English). "SaveModel": "Would you like to save project?" -> "SaveModel": "Would you like to save the project?" (unless too short of space?),"SplittedExamples": "Splitted thermal bridges" -> "SplittedExamples": "Split thermal bridges" (And ideally change the ID too. 'splitted' is not a word in English - past participle of 'to split' is 'split')
"ExamplesCat3": "Ceil" -> "ExamplesCat3": "Ceiling" "CrawlCeilThermR": "Crawl ceil thermal resistance:" -> "CrawlCeilThermR": "Crawl space ceiling thermal resistance:" "CrawlAirAreaSize": "Openings area divided by crawl perimeter:" -> "CrawlAirAreaSize": "Openings area divided by crawl space perimeter:" "CrawlHeight": "Crawl height from ground:" -> "CrawlHeight": "Crawl space height from ground:" "MeanCrawlDeep": "Mean crawl depth:" -> "MeanCrawlDeep": "Mean crawl space depth:" "BasementCeilThermR": "Basement ceil thermal resistance:" -> "BasementCeilThermR": "Basement ceiling thermal resistance:" "Tutorial_26": "Wall with cleats" -> "Tutorial_26": "Wall with studs", "FrontVolume": "Bring up volume in the stack" -> "FrontVolume": "Bring volume up in the stack", | "BackVolume": "Bring down volume in the stack" -> "BackVolume": "Bring volume down in the stack", "DxfHasNoLayer": "DXF file doesn't contain any layer!" -> "DxfHasNoLayer": "DXF file doesn't contain any layers!" "DxfHasNoValidPolyline": "DXF file doesn't contain any valid polyline without self intersec\| tion!", -> "DxfHasNoValidPolyline": "DXF file doesn't contain any valid polylines without self intersec\| tion!", "ExamplesCat7": "Plancher intermédiaire ψ1 – ψ2" -> "ExamplesCat7": "Intermediate floor ψ1 – ψ2" "ExamplesCat9": "Ground floor under earth" -> "ExamplesCat9": "Ground floor below ground level" "ExamplesCat11": "Ground floor on crawl" -> "ExamplesCat11": "Ground floor above crawl space" "Example_3": "Outside corner with plaster cladding" -> "Example_3": "Outside corner, wet plastered" "Example_8": "Isolated intermediate floor" -> "Example_8": "Insulated intermediate floor" "Tutorial_29": "Galss - frame junction" -> "Tutorial_29": "Glass - frame junction"This one is tricky: "ExamplesCat6": "Acroter" and I'm really not sure what this is in english. The example shows a dwarf wall on the roof of a building. That is normally called a 'parapet'.
Apparently an acroter is a pedestal or plinth for a statue. (borrowed from French) Another definition says "an ornamental element placed on the apex or corners of a pediment or the top of a roof in classical architecture, typically depicting decorative figures or motifs" I've never heard of it so I do wonder what concept in English is wanted? Parapet? Plinth? Eaves? Pedestal? My best guess is 'parapet' (or 'parapet wall'): https://www.partsofaroof.com/parapet-wall
* translated the quick-start guide and corrected several English UI strings/typos * moved documentation to `/usr/share/doc/conducteo/` (while keeping a copy for in-application access)
Wouldn't it be better to set the path to read docs for internal use (at least in the debian build) to be /usr/share/doc/conducteo/ rather than have two copies? Each copy is 11MB. Or at least put in a symlink in /usr/share/conducteo/documentation which points to /usr/share/doc/conducteo/ Checking policy I see that examples should go in /usr/share/doc/conducteo/examples (not /usr/share/conducteo/examples) so link required there too
* replaced the previous proprietary icon set with open-source icons (throughout the software and the documentation) * removed embedded libraries and switched to system packages (`eigen3`, `dxflib`)* removed the dependency on Boost * completed and updated `debian/copyright`
That looks good now.
* improved package description and added notes regarding French documentation/material database* fixed version patch reporting (`5.0.1`)Regarding translation/proofreading, I would very much appreciate your help. I recently moved translations to external JSON files to make localisation easier, and improving the English wording of the UI, documentation and materials database would definitely help adoption outside French-speaking users.
OK. Above is all the stuff in the UI in the json file.I went through the materials database, fishing out the uniq names and trying to translate them all. This is quite tricky in places with things like various sorts of concrete, plasters and species of wood.
I'll send a separate mail about that. The package builds fine for me on both stable and unstable. I see the 'this is the first time you have run conducteo...' dialog (in English now :-) However I clicked 'yes' for docs but did not see the quickstart_en.pdf file, so I suspect something has gone wrong with the creation of an English version and/or the moving files around. (but 'help->Documentation->'Quickstart guide' does get me the English quickstart guide) Wookey -- Principal hats: Wookware, Debian http://wookware.org/ Matrix: @wookey:matrix.org
signature.asc
Description: PGP signature
