On 2026-05-18 12:57 +0200, [email protected] wrote:
Hi everyone,I have now addressed the remaining review points and uploaded an updated package to mentors (`5.0.2-1`).
That was a quick turnaround to include all the materials translation I sent last night!
Changes since the previous upload include: * moved documentation to `/usr/share/doc/conducteo/`
final deb 12MB rather than 22MB without all the docs duplicated, so that's good.
* moved examples to `/usr/share/doc/conducteo/examples/` * added `doc-base` integration * fixed the quickstart guide opening on first launch
confirmed
* added translation support for the materials database
Excellent. This is now easily useable by non-French speakers. Thanks for that work. One bit of Frenchness still showing through is the 'user-defined database', which still shows French material names. Those should be showing translated names too? I'm not sure where that list comes from (I have not tried to add or remove any in that list). Hmm, adding one I see that you get to set the name yourself (they are not copied from the main, translated database). So that explains it, but it still looks odd to have a 'user-defined' list of 20 materials in a foreign language by default. You could just make it empty by default, or pick a couple of examples that look the same in French and English like 'Aluminium' and 'Air' (so it's easy to see that the feature is there)?
I also rebuilt and tested the package in a clean Debian environment. Documentation, examples and localisation now work correctly.Thank you again for your detailed review and suggestions. If you have time for another look, I would greatly appreciate it.
This package is now fine to upload to debian. There are still things to improve (like the user-defined list above, and full translation of the main docs), but we are done from a technical debian standards and basic non-French useability point of view. Do you want to fix the user-defined database thing first and then I upload, or shall I go with this one? Wookey -- Principal hats: Wookware, Debian http://wookware.org/ Matrix: @wookey:matrix.org
signature.asc
Description: PGP signature
