+1 for reference, it reads well and makes sense to me
On 2025/02/24 18:15:02 Tzu-ping Chung wrote:
> I like StartsFrom, but “DeadlineStartsFrom” sounds like when the deadline is.
> It should have another word in front.
>
> DeadlineReference sounds reasonable to me. Something like DeadlineBase or
> DeadlineBasis could be possible too, although I actually like reference
> better.
>
> I kind of feel DeadlineMeasureFrom reads OK, but that’s long. And it makes
> less sense if you don’t add a timedelta to it (which I assume you can do?)
>
>
> > On 25 Feb 2025, at 02:07, Jarek Potiuk <ja...@potiuk.com> wrote:
> >
> > Why not `DeadlineStartsFrom` ?
> >
> >
> >
> >
> > On Mon, Feb 24, 2025 at 7:00 PM Ferruzzi, Dennis
> > <ferru...@amazon.com.invalid> wrote:
> >
> >> Hey folks. I need to narrow down the name for one of the parameters on
> >> the Deadline Alerts work and I'm fishing for suggestions.
> >>
> >> TLDR: need_by_date = {some existing timestamp} + {a user-defined
> >> timedelta}
> >>
> >> The existing timestamp could be dynamic (like when the dagrun is queued or
> >> when a specific task stars, etc), or fixed datetime.
> >>
> >> So in practice this will look something like:
> >>
> >> need_by = DeadlineTrigger.DAGRUN_QUEUED + timedelta(hours=1)
> >>
> >> where the DeadlineTrigger is the part we are trying to rename.
> >>
> >> I initially used Anchor in the AIP for lack of a better name and it was
> >> universally hated. I like Trigger better, but that name is already
> >> overloaded in Airflow so I don't want to reuse it. Maybe Reference?
> >>
> >> need_by = DeadlineReference.DAGRUN_STARTED + timedelta(minutes=30?
> >>
> >> Please throw some other suggestions or naming thoughts on the pile and
> >> maybe we can come up with something good.
> >>
> >>
> >> - ferruzzi
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org
> For additional commands, e-mail: dev-h...@airflow.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org
For additional commands, e-mail: dev-h...@airflow.apache.org
