[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=720953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720953
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 15:51
Start Date: 04/Feb/22 15:51
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1030113075
We already agreed to rename fields from fieldName to _fieldName when we
merged the new editorconfig. This is taking that into account. What this is
really doing is deprecating an publicly exposed field. Almost everything I
have ever read about the C# language says don't do this unless necessary.
Publicly exposing this field is unnecessary since it already has a public
accessible property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720953)
Time Spent: 1h 20m (was: 1h 10m)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
