[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723825
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 17:17
Start Date: 09/Feb/22 17:17
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034003004
First fix CA/SA/IDE "suggestions" and then start enforcing them. Minor
formatting I don't mind doing big PRs, but I find it is rare that people will
take the time to look at large PRs (@martin-g has already requested that I keep
them small).
If I touch this many files it will find issues that will not pass CodeQL so
we will have to address those as well.
The biggest thing I'm trying to do is maintain backwards compatibility when
making what I really call maintainability changes. I have laid out the process
I follow above
(https://github.com/apache/avro/pull/1519#issuecomment-1030219518).
One of the things I'm specifically avoiding is class/struct formatting.
(order of fields, properties, constructors, methods, etc.) I prefer them to be
sorted a specific way, but that can really mess up git history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723825)
Time Spent: 2h 40m (was: 2.5h)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
