[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=720970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720970
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 16:00
Start Date: 04/Feb/22 16:00
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1030121418
>>> We already agreed to rename fields from fieldName to _fieldName when we
merged the new editorconfig
Not really. The editorconfig and the codestyle is the first iteration of
standardizing the styles and by no means what we should follow. The steps
should be starting to turn off certain messages we dont worry about or we dont
want to support, since the code base here is fairly mature. Some warnings or
suggestions should be turned off. Some suggestions should be elimibnated by
fixing the code. However by no means the codestyle being checked in is the
written in stone style we must follow and modify the code for.
In the case of the _, IMO that warning or suggestion should be turned off,
instead of changing every member to have an underscore. My point back in that
ticket was, that the baseline should be the MS codestyle and we create
overrides where we do some things differently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720970)
Time Spent: 1.5h (was: 1h 20m)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
