[ 
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723836
 ]

ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 17:21
            Start Date: 09/Feb/22 17:21
    Worklog Time Spent: 10m 
      Work Description: zcsizmadia edited a comment on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034007074


   IMO those the code style and analysis  messages were meant to be a baseline. 
IMO many of them should be turned off and put into silent mode. That is the 
reason I stated couple of times, that I think wes hould have a discussion about 
which message or suggestion or warning should be simply turned off an d which 
should be fixed by changing the code
   
   IMO the PRs should be grouped by the message they hide
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723836)
    Time Spent: 3h  (was: 2h 50m)

>  Remove accessible field value from GenericFixed
> ------------------------------------------------
>
>                 Key: AVRO-3368
>                 URL: https://issues.apache.org/jira/browse/AVRO-3368
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.0
>            Reporter: Kyle Schoonover
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
>     get { return _value; }
> }        
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to 
> _value



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to