[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=721051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721051
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 17:56
Start Date: 04/Feb/22 17:56
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1030219518
Currently my team uses both the Avro library and Confluents library to work
with the schema repository. And the biggest reason that I am going through
this process is this merge request:
https://github.com/confluentinc/confluent-kafka-dotnet/pull/1643
The other reason is because I expect that my team will start deprecating
using C# / .Net altogether and move to Java. So until that happens I'm going
to try to improve the quality and maintainability of this project.
So I can either take the time to bring the library incrementally up to
standards or I can sit around and wait to review these large sweeping changes.
Typically this is how I will approach it:
Follow the standards (Code Analysis, StyleCop, etc) because I assume that is
how people want it done. Now this project has so many "suggestions" that it's
going to take a while to do this incrementally and maintain backwards
compatibility. Also CodeQL caught something just because I touched a file,
still had to correct the problem to pass the CI/CD.
Next step will be to start correcting code bugs.
- Better implementations
- Better exception handling
- More test coverage
Last I will start adding new features. This will probably lead to going for
parity with the Java library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721051)
Time Spent: 1h 40m (was: 1.5h)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
