On Wed, Jan 31, 2018 at 2:09 PM, Ahmet Altay <al...@google.com> wrote:
> This will require a change in the Beam code, because image names are > hardcoded in to code (python) and configuration (java). RC1 as it is will > not work correctly with Cloud Dataflow. > Please ignore this. Looking at the issues Alan created this does not seem to be correct. And RC1 should work as expected once Google related step is completed. > > On Wed, Jan 31, 2018 at 2:08 PM, Reuven Lax <re...@google.com> wrote: > >> Hopefully we can validate soon. I believe some of the delays are because >> of integrating major changes done over the last week (e.g. Java 8 >> migration). >> >> On Wed, Jan 31, 2018 at 2:04 PM, Ismaël Mejía <ieme...@gmail.com> wrote: >> >>> What is the common procedure in cases like this ? Because it doesn't >>> seems that it needs a re-vote, just an extra day or two for >>> validation, any ideas JB ? >>> >>> On Wed, Jan 31, 2018 at 10:41 PM, Alan Myrvold <amyrv...@google.com> >>> wrote: >>> > Yes, it is a dataflow step. Happy to test this again when they are >>> > available. >>> > >>> > On Wed, Jan 31, 2018 at 1:39 PM, Jean-Baptiste Onofré <j...@nanthrax.net >>> > >>> > wrote: >>> >> >>> >> OK, I think I understood ;) >>> >> >>> >> So it's not "directly" related to Beam itself (it's more a Dataflow >>> step >>> >> to perform). >>> >> >>> >> @Alan, I think it's better to test first and then cast the vote. This >>> kind >>> >> of tests are valuable to validate the release and make sense. But vote >>> >> should represent the state of the Beam release. So I think -1 vote is >>> a bit >>> >> too early before the test. >>> >> >>> >> Thanks ! >>> >> Regards >>> >> JB >>> >> >>> >> On 31/01/2018 22:33, Reuven Lax wrote: >>> >>> >>> >>> It's just a step that needs to be peformed before the new release >>> works >>> >>> on Dataflow. Alan is saying that we've been unable to validate >>> Dataflow so >>> >>> far, as worker images are not yet built. Hopefully they'll be built >>> soon, >>> >>> and we'll be able to validate. >>> >>> >>> >>> On Wed, Jan 31, 2018 at 1:31 PM, Jean-Baptiste Onofré < >>> j...@nanthrax.net >>> >>> <mailto:j...@nanthrax.net>> wrote: >>> >>> >>> >>> Hi Alan >>> >>> >>> >>> does it related to change in the codebase or in a >>> dependency/related >>> >>> project ? >>> >>> >>> >>> I mean: is it something we have to fix/change in Beam ? >>> >>> >>> >>> Just curious as I'm not sure what you mean by "worker images" ;) >>> >>> >>> >>> Thanks ! >>> >>> Regards >>> >>> JB >>> >>> >>> >>> On 31/01/2018 22:18, Alan Myrvold wrote: >>> >>> >>> >>> -1 (for now, hope to change this) >>> >>> >>> >>> Dataflow runner jobs are failing for me with 2.3.0 RC1, for >>> both >>> >>> Java and Python. >>> >>> >>> >>> This is not an issues with the 2.3.0 RC1 SDK, we (google) >>> need >>> >>> to release worker images. >>> >>> >>> >>> I have assigned these bugs to myself, and will be working to >>> >>> help get these workers released. >>> >>> >>> >>> [BEAM-3584] Java dataflow job fails with 2.3.0 RC1, due to >>> >>> missing worker image >>> >>> [BEAM-3585] Python dataflow job fails with 2.3.0 RC1, due to >>> >>> missing worker image >>> >>> >>> >>> On Wed, Jan 31, 2018 at 6:12 AM, Jean-Baptiste Onofré >>> >>> <j...@nanthrax.net <mailto:j...@nanthrax.net> >>> >>> <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>>> wrote: >>> >>> >>> >>> Thanks Kenn, >>> >>> >>> >>> I prepared the list of tasks I did. I will complete >>> where >>> >>> release is >>> >>> out. >>> >>> >>> >>> Regards >>> >>> JB >>> >>> >>> >>> On 01/31/2018 03:07 PM, Kenneth Knowles wrote: >>> >>> > I've cloned the release validation spreadsheet: >>> >>> > >>> >>> > https://s.apache.org/beam-2.3.0-release-validation >>> >>> <https://s.apache.org/beam-2.3.0-release-validation> >>> >>> <https://s.apache.org/beam-2.3.0-release-validation >>> >>> <https://s.apache.org/beam-2.3.0-release-validation>> >>> >>> > >>> >>> > If you plan to perform a manual validation task, >>> please >>> >>> sign up so multiple >>> >>> > people don't waste effort. >>> >>> > >>> >>> > Alan & JB, as far as your pairing up to automate more, >>> >>> anything manual on this >>> >>> > sheet should be considered. >>> >>> > >>> >>> > Kenn >>> >>> > >>> >>> > On Wed, Jan 31, 2018 at 5:59 AM, Jean-Baptiste Onofré >>> >>> <j...@nanthrax.net <mailto:j...@nanthrax.net> >>> >>> <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>> >>> >>> > <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net> >>> >>> <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>>>> wrote: >>> >>> > >>> >>> > +1 (binding) >>> >>> > >>> >>> > Casting my own +1 ;) >>> >>> > >>> >>> > Regards >>> >>> > JB >>> >>> > >>> >>> > On 01/30/2018 09:04 AM, Jean-Baptiste Onofré >>> wrote: >>> >>> > > Hi everyone, >>> >>> > > >>> >>> > > Please review and vote on the release candidate >>> #1 >>> >>> for the version 2.3.0, as >>> >>> > > follows: >>> >>> > > >>> >>> > > [ ] +1, Approve the release >>> >>> > > [ ] -1, Do not approve the release (please >>> provide >>> >>> specific comments) >>> >>> > > >>> >>> > > >>> >>> > > The complete staging area is available for your >>> >>> review, which includes: >>> >>> > > * JIRA release notes [1], >>> >>> > > * the official Apache source release to be >>> deployed >>> >>> to dist.apache.org <http://dist.apache.org> >>> >>> <http://dist.apache.org> >>> >>> > <http://dist.apache.org> [2], >>> >>> > > which is signed with the key with fingerprint >>> >>> C8282E76 [3], >>> >>> > > * all artifacts to be deployed to the Maven >>> Central >>> >>> Repository [4], >>> >>> > > * source code tag "v2.3.0-RC1" [5], >>> >>> > > * website pull request listing the release and >>> >>> publishing the API reference >>> >>> > > manual [6]. >>> >>> > > * Java artifacts were built with Maven 3.3.9 and >>> >>> Oracle JDK 1.8.0_111. >>> >>> > > * Python artifacts are deployed along with the >>> >>> source release to the >>> >>> > > dist.apache.org <http://dist.apache.org> >>> >>> <http://dist.apache.org> >>> >>> <http://dist.apache.org> [2]. >>> >>> > > >>> >>> > > The vote will be open for at least 72 hours. It >>> is >>> >>> adopted by majority >>> >>> > approval, >>> >>> > > with at least 3 PMC affirmative votes. >>> >>> > > >>> >>> > > Thanks, >>> >>> > > JB >>> >>> > > >>> >>> > > [1] >>> >>> > > >>> >>> > >>> >>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >>> ctId=12319527&version=12341608 >>> >>> >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608> >>> >>> >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608 >>> >>> >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608>> >>> >>> > >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608 >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608> >>> >>> >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608 >>> >>> >>> >>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >>> ectId=12319527&version=12341608>>> >>> >>> > > [2] >>> >>> https://dist.apache.org/repos/dist/dev/beam/2.3.0/ >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/> >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/ >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/>> >>> >>> > <https://dist.apache.org/repo >>> s/dist/dev/beam/2.3.0/ >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/> >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/ >>> >>> <https://dist.apache.org/repos/dist/dev/beam/2.3.0/>>> >>> >>> > > [3] >>> >>> https://dist.apache.org/repos/dist/release/beam/KEYS >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS> >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS>> >>> >>> > <https://dist.apache.org/repo >>> s/dist/release/beam/KEYS >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS> >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS >>> >>> <https://dist.apache.org/repos/dist/release/beam/KEYS>>> >>> >>> > > [4] >>> >>> >>> >>> https://repository.apache.org/content/repositories/orgapache >>> beam-1026/ >>> >>> >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/> >>> >>> >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/ >>> >>> >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/>> >>> >>> > >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/ >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/> >>> >>> >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/ >>> >>> >>> >>> <https://repository.apache.org/content/repositories/orgapach >>> ebeam-1026/>>> >>> >>> > > [5] https://github.com/apache/beam >>> /tree/v2.3.0-RC1 >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1> >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1 >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1>> >>> >>> > <https://github.com/apache/beam/tree/v2.3.0-RC1 >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1> >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1 >>> >>> <https://github.com/apache/beam/tree/v2.3.0-RC1>>> >>> >>> > > [6] https://github.com/apache/beam >>> -site/pull/381 >>> >>> <https://github.com/apache/beam-site/pull/381> >>> >>> <https://github.com/apache/beam-site/pull/381 >>> >>> <https://github.com/apache/beam-site/pull/381>> >>> >>> > <https://github.com/apache/beam-site/pull/381 >>> >>> <https://github.com/apache/beam-site/pull/381> >>> >>> <https://github.com/apache/beam-site/pull/381 >>> >>> <https://github.com/apache/beam-site/pull/381>>> >>> >>> > > >>> >>> > >>> >>> > -- >>> >>> > Jean-Baptiste Onofré >>> >>> > jbono...@apache.org <mailto:jbono...@apache.org> >>> >>> <mailto:jbono...@apache.org <mailto:jbono...@apache.org>> >>> >>> <mailto:jbono...@apache.org <mailto:jbono...@apache.org >>> > >>> >>> <mailto:jbono...@apache.org <mailto:jbono...@apache.org>>> >>> >>> > http://blog.nanthrax.net >>> >>> > Talend - http://www.talend.com >>> >>> > >>> >>> > >>> >>> >>> >>> -- >>> >>> Jean-Baptiste Onofré >>> >>> jbono...@apache.org <mailto:jbono...@apache.org> >>> >>> <mailto:jbono...@apache.org <mailto:jbono...@apache.org>> >>> >>> http://blog.nanthrax.net >>> >>> Talend - http://www.talend.com >>> >>> >>> >>> >>> >>> >>> > >>> >> >> >