[ 
https://issues.apache.org/jira/browse/BIGTOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045666#comment-14045666
 ] 

Martin Bukatovic commented on BIGTOP-1342:
------------------------------------------

I found a bug in my patch: {{hcfs.root.groupname}} hack is not working properly
(I didn't find it out because I left {{dfs.permissions.superusergroup}} set to
root).

Which raises a question: Is it ok to expect that
{{dfs.permissions.superusergroup}} should not be set at all with alternative
Hadoop filesystem such as GlusterFS? My patch as it is expects this and tries
to allow you to redefine superuser group while ignoring
{{dfs.permissions.superusergroup}}, but I didn't realize that the expansion of
the supergroup is done somewhere deeper in the Hadoop code.


> Make TestCLI usable for both HDFS and HCFS
> ------------------------------------------
>
>                 Key: BIGTOP-1342
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1342
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.8.0
>            Reporter: Martin Bukatovic
>         Attachments: BIGTOP-1342.1.patch
>
>
> Current TestCLI test cases are currently only runnable on HDFS.  Since the 
> most
> test cases are applicable on any hadoop filesystem, it makes sense to
> make it general in hcfs sense.
> While most test cases are hcfs generic, some cases are only applicable to 
> HDFS,
> so I propose split the current code into:
>  * general HCFS superclass (with most cases in {{testHCFSConf.xml}} file)
>  * HDFS specific subclass (with hdfs only cases in {{testHDFSConf.xml}})
> I would like to keep {{testHCFSConf.xml}} as a common base for any hadoop
> filesystem, which would require introduction of several additional variables 
> to
> catch minor differences between GlusterFS and HDFS. This should be good enough
> for other hcfs implementations as well, but I didn't tested it.
> Before proposing patch for this, it make sense to have the following resolved:
>  * BIGTOP-1341 TestCLI cleanup
>  * BIGTOP-1334 Add DFS support to TestCLI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to