[
https://issues.apache.org/jira/browse/BIGTOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057938#comment-14057938
]
jay vyas commented on BIGTOP-1342:
----------------------------------
For those busy to read these changes, ill summarize here:
1) First, we Add changes +/- to FSCmdExecutor.java. That is because we move
the package.
2) Then, we see a similar thing with TestCLI (the new HCFS compliant test class)
3) The tests which are HDFS Specific are now in TestHDFSCli
4) There are now 2 XML files (HCFSConf.xml and HDFSConf.xml)
Overall this is a good patch and a very clean solution IMO : We have now peeled
out HDFS Specific operations entirely, so anyone with a HCFS can do really
rigorous testing of their file system.
I'll do full review and test again tonite. until then, any objections to
commit if its all working?
> Make TestCLI usable for both HDFS and HCFS
> ------------------------------------------
>
> Key: BIGTOP-1342
> URL: https://issues.apache.org/jira/browse/BIGTOP-1342
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.8.0
> Reporter: Martin Bukatovic
> Attachments: BIGTOP-1342.1.patch, BIGTOP-1342.2.patch
>
>
> Current TestCLI test cases are currently only runnable on HDFS. Since the
> most
> test cases are applicable on any hadoop filesystem, it makes sense to
> make it general in hcfs sense.
> While most test cases are hcfs generic, some cases are only applicable to
> HDFS,
> so I propose split the current code into:
> * general HCFS superclass (with most cases in {{testHCFSConf.xml}} file)
> * HDFS specific subclass (with hdfs only cases in {{testHDFSConf.xml}})
> I would like to keep {{testHCFSConf.xml}} as a common base for any hadoop
> filesystem, which would require introduction of several additional variables
> to
> catch minor differences between GlusterFS and HDFS. This should be good enough
> for other hcfs implementations as well, but I didn't tested it.
> Before proposing patch for this, it make sense to have the following resolved:
> * BIGTOP-1341 TestCLI cleanup
> * BIGTOP-1334 Add DFS support to TestCLI
--
This message was sent by Atlassian JIRA
(v6.2#6252)
