[
https://issues.apache.org/jira/browse/BIGTOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047703#comment-14047703
]
Martin Bukatovic commented on BIGTOP-1342:
------------------------------------------
Oh, yes. You are right, the change of xml file it too big to review.
To make this change little easier to consume, here you can see what I did with
the test config file:
* create HCFS test file:
{noformat}
cp testHDFSConf.xml testHCFSConf.xml
{noformat}
* introduce {{HCFS_SCHEME}} variable:
{noformat}
sed -i 's/hdfs:/HCFS_SCHEME/g' testHCFSConf.xml
{noformat}
* introduce {{HCFS_DIRSIZE}} variable:
{noformat}
sed -i '/<expected-output>^drwx/s/0/HCFS_DIRSIZE/' testHCFSConf.xml
{noformat}
* introduce {{HCFS_NNMATCH}} variable:
{noformat}
sed -i
's!HCFS_SCHEME//\\w+\[-\.a-z0-9\]\*(:\[0-9\]+)?!HCFS_SCHEME//HCFS_NNMATCH!'
testHCFSConf.xml
{noformat}
* disable test cases not applicable to HCFS: commentiog out cases: 242 294 295
296 297 301 302 305 306 in {{testHCFSConf.xml}}
* removed all hcfs test cases from {{testHDFSConf.xml}} ({{testHCFSConf.xml}}
contains just 242 294 295 296 297 301 302 305 306 testcases now)
* left original version of test config file available as
{{testHCFSConf.pristine.xml}}
Also you can review the changes in my personal devel branch on github:
https://github.com/mbukatov/bigtop/commits/local_BIGTOP-1342-devel
Please note that this change expects BIGTOP-1341 to be resolved. I splitted the
effort into 2 JIRAs because it would be hard to discuss such big change in
singe JIRA, moreover I expedted that this hcfs patch will needs some tweaking,
while TestCLI cleanup would be easier to get merged.
> Make TestCLI usable for both HDFS and HCFS
> ------------------------------------------
>
> Key: BIGTOP-1342
> URL: https://issues.apache.org/jira/browse/BIGTOP-1342
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.8.0
> Reporter: Martin Bukatovic
> Attachments: BIGTOP-1342.1.patch
>
>
> Current TestCLI test cases are currently only runnable on HDFS. Since the
> most
> test cases are applicable on any hadoop filesystem, it makes sense to
> make it general in hcfs sense.
> While most test cases are hcfs generic, some cases are only applicable to
> HDFS,
> so I propose split the current code into:
> * general HCFS superclass (with most cases in {{testHCFSConf.xml}} file)
> * HDFS specific subclass (with hdfs only cases in {{testHDFSConf.xml}})
> I would like to keep {{testHCFSConf.xml}} as a common base for any hadoop
> filesystem, which would require introduction of several additional variables
> to
> catch minor differences between GlusterFS and HDFS. This should be good enough
> for other hcfs implementations as well, but I didn't tested it.
> Before proposing patch for this, it make sense to have the following resolved:
> * BIGTOP-1341 TestCLI cleanup
> * BIGTOP-1334 Add DFS support to TestCLI
--
This message was sent by Atlassian JIRA
(v6.2#6252)
