[ 
https://issues.apache.org/jira/browse/BIGTOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048655#comment-14048655
 ] 

Martin Bukatovic commented on BIGTOP-1342:
------------------------------------------

{quote}
Do you think we should create a JIRA in Hadoop which indicates that there 
should be a superuser parameter in the hadoop common namespace ( shouldnt own 
the notion of a superuser other file systems have super users to !)
{quote}

So are you suggesting to move {{dfs.permissions.superusergroup}} from 
{{hdfs-site.xml}} into something like {{hcfs.permissions.superusergroup}} in 
let's say {{core-site.xml}} or even {{hcfs-site.xml}}? While I'm not sure if it 
would be easy to convince Hadoop upstream about this, creating JIRA for it in 
Hadoop is actually a good idea. This issue definitely deserves an official 
upstream solution applicable to any Hadoop filesystem. Do we have other dfs 
properties related to GlusterFS like this one?

{quote}
Can we also suggest alternative way of defining superuser for this test ? I 
think its a little self-defeating to depend on an HDFS parameter when we're 
trying to make the tests HCFS compliant – but i totally see why you are using 
it - let me know if im missing something. 
{quote}

I'm using it because I need to keep HDFS compatibility, but you can redefine it 
using {{hcfs.root.groupname}} property. So I would say that the patch already 
provides alternative way of defining superuser. See the code:

{noformat}
supergroup = System.getProperty("hcfs.root.groupname", 
conf.get(DFSConfigKeys.DFS_PERMISSIONS_SUPERUSERGROUP_KEY));
{noformat}

{quote}
Does this take into account the semantics we agreed on in the BIGTOP-1200 patch 
( just a quick thought).
{quote}

Well I expect that superuser and supergroup for GlusterFS run is root ( see 
properties {{-Dhcfs.root.username=root  -Dhcfs.root.groupname=root}} from 
comment above). Or do you have something else to point out?


> Make TestCLI usable for both HDFS and HCFS
> ------------------------------------------
>
>                 Key: BIGTOP-1342
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1342
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.8.0
>            Reporter: Martin Bukatovic
>         Attachments: BIGTOP-1342.1.patch
>
>
> Current TestCLI test cases are currently only runnable on HDFS.  Since the 
> most
> test cases are applicable on any hadoop filesystem, it makes sense to
> make it general in hcfs sense.
> While most test cases are hcfs generic, some cases are only applicable to 
> HDFS,
> so I propose split the current code into:
>  * general HCFS superclass (with most cases in {{testHCFSConf.xml}} file)
>  * HDFS specific subclass (with hdfs only cases in {{testHDFSConf.xml}})
> I would like to keep {{testHCFSConf.xml}} as a common base for any hadoop
> filesystem, which would require introduction of several additional variables 
> to
> catch minor differences between GlusterFS and HDFS. This should be good enough
> for other hcfs implementations as well, but I didn't tested it.
> Before proposing patch for this, it make sense to have the following resolved:
>  * BIGTOP-1341 TestCLI cleanup
>  * BIGTOP-1334 Add DFS support to TestCLI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to