[jira] [Commented] (BIGTOP-1579) Improve Bigtop Toolchain : Create diff files

[Konstantin Boudnik (JIRA)]

    [ 
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277629#comment-14277629
 ] 

Konstantin Boudnik commented on BIGTOP-1579:
--------------------------------------------

Now I see that default unpack method, eg {{tar -xzf}} isn't there anymore. For 
some reason you have removed the logic around choosing how the archive is 
unpacked - tar vs unzip - and now only are using unzip command line.

Also, the logic here
{code}
    if (TARBALL_SRC.empty || TARBALL_SRC.endsWith('.zip')) {
      if (TARBALL_SRC.empty) {
{code}
seems to be overly complex, isn't it? Would it work if something like that is 
done:
{code}
    def UNPACK = "tar -xzf"
    if (TARBALL_SRC.endsWith('.zip')) {
      UNPACK = "unzip"
    }
      if (TARBALL_SRC.empty) {
        // if no tar file needed (i.e. bigtop-utils)
        // create some contents to pack later
        copy {
          from 'LICENSE'
          into TAR_DIR
        }
      } else {
        exec {
          workingDir TAR_DIR
          commandLine "$UNPACK $DOWNLOAD_DST".split(' ')
        }
....
{code} eg the entire {{if (TARBALL_SRC.empty || TARBALL_SRC.endsWith('.zip'))}} 
is gone
Seems to be a bit less code and a simpler logic to follow, no?

> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
>                 Key: BIGTOP-1579
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1579
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>             Fix For: 0.9.0
>
>         Attachments: 0001-BIGTOP-1579-Implement-patching-for-Bigtop.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0002-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the 
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild / 
> debuild to apply patches. But right now the gradle script is not flexible 
> enough. Since make is now obsolete we can improve this situation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)