> Am 14.01.2015 um 21:39 schrieb Konstantin Boudnik (JIRA) <[email protected]>: > > > [ > https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277629#comment-14277629 > ] > > Konstantin Boudnik commented on BIGTOP-1579: > -------------------------------------------- > > Now I see that default unpack method, eg {{tar -xzf}} isn't there anymore. > For some reason you have removed the logic around choosing how the archive is > unpacked - tar vs unzip - and now only are using unzip command line. >
The logic before was complex since it used misleading naming of variables. We have 3 cases : 1) Non existing sources: We need to create a tar with LICENSE file 2) ZIP Files: Have to be converted to tar files. With the corner case that it may have to move one level up. 3) TAR Files. Which have simply to be renamed. In the case 1 and 2 with have to create a tar afterwards after creating/unpacking In case 3 a simple rename does the work. ---- A code path with UNPACK = "tar -xzf" was never used before. instead the side effect of PATCHES equals empty was used to mark empty packets, which is misleading — at least. — Please reconsider. Olaf
signature.asc
Description: Message signed with OpenPGP using GPGMail
