John,

On 23 May 2016 at 10:34, John McCabe <[email protected]> wrote:

> Naming of the package within Brew *only*, it does not impact the resulting
> binary naming at all:
>
> # brew install apache-brooklyn-cli
> # br login http://localhost:8081


Excellent - my concerns were misplaced :-)


> *Maintainers:*
> Brew don't appear to have support for a maintainer tag, but adding a
> maintainer in a comment is feasible.
>
> What maintainer address would you recommend?
>

No need to worry. If it's not common practice in the Brew world to name a
maintainer (like it is in the Debian world, for example), then just comply
with their existing practices.

I would prefer that at [1] you name the class `ApacheBrooklyn` instead of
`Brooklyn` (but the naming of private variables inside the class is fine as
it is).

Thanks for responding to my concerns! I have no other objections to this,
so go ahead.

Cheers
Richard.


[1]
https://github.com/Homebrew/homebrew-core/pull/1326/files#diff-476062d25b84e180693641a30b797a5aR5

Reply via email to