ahgittin commented on a change in pull request #164: auto-set a name for the
app in quick-launch, and
URL: https://github.com/apache/brooklyn-ui/pull/164#discussion_r366792711
##########
File path: ui-modules/utils/quick-launch/quick-launch.js
##########
@@ -47,11 +47,21 @@ export function quickLaunchDirective() {
function controller($scope, $http, $location, brSnackbar) {
$scope.deploying = false;
$scope.model = {
- newConfigFormOpen: false
+ newConfigFormOpen: false,
+
+ // should never be null, so the placeholder in UI for model.name
will never be used;
+ // hence autofocus is disabled
Review comment:
there's a good chance that the location and the config don't need any change
so in this instance autofocussing on anything could be misleading. arguably we
should check if anything is required and make the first required thing
autofocus but not sure that's worth the work, and if nothing is required it's
unclear to we select "deploy" (even though user might want to change
non-required things) or something non-required (which would be confusing).
better IMO to have the tab set just before the first field so it's easy to
select using mouse or keyboard - but let's chat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
