ahgittin commented on a change in pull request #164: auto-set a name for the
app in quick-launch, and
URL: https://github.com/apache/brooklyn-ui/pull/164#discussion_r366793232
##########
File path: ui-modules/utils/quick-launch/quick-launch.html
##########
@@ -39,7 +39,8 @@ <h4 class="media-heading">{{app.name ||
app.symbolicName}}</h4>
<h3 class="quick-launch-section-title">Name</h3>
<div class="quick-launch-section-content">
<div class="form-group">
- <input class="form-control" type="text"
ng-model="model.name" ng-disabled="deploying" name="name" placeholder="Choose a
name for this application (Optional)" autofocus />
+ <input class="form-control" type="text"
ng-model="model.name" ng-disabled="deploying" name="name"
+ placeholder="{{ 'Choose a name for this application
(Optional)' }}" />
Review comment:
for me using it, it seems best not to have any with `autofocus` -- see below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
