Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#discussion_r29320635
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakClusterImpl.java ---
@@ -79,7 +82,7 @@ public void start(Collection<? extends Location>
locations) {
//FIXME: add a quorum to tolerate failed nodes before setting on
fire.
Optional<Entity> anyNode = Iterables.tryFind(getMembers(),
Predicates.and(
- Predicates.instanceOf(RiakNode.class),
+ Predicates.or(Predicates.instanceOf(RiakNode.class),
Predicates.instanceOf(SameServerEntity.class)),
EntityPredicates.attributeEqualTo(RiakNode.RIAK_NODE_HAS_JOINED_CLUSTER, true),
--- End diff --
The entity assumes that the members are RiakNodes, thus relaying on
specific behaviour from them. For example `RIAK_NODE_HAS_JOINED_CLUSTER` will
be set by the node, it's not managed by the cluster. Another example is calling
the effector `REMOVE_FROM_CLUSTER` on the members.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
