Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-97450244
Tested the current branch - I get NPE in Solr:
```
java.lang.NullPointerException: null value in entry: solrPort=null
at
com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:135)
at
com.google.common.collect.ImmutableMap$Builder.put(ImmutableMap.java:206)
at
brooklyn.entity.nosql.solr.SolrServerSshDriver.getPortMap(SolrServerSshDriver.java:100)
...
```
Riak also fails (tested on Ubuntu box) because apt-get tries to install
both entities at the same time.
Also the above considerations about `SameServerEntity`
I think the way to go is:
* Make Solr child of Riak
* Change the `SEARCH_SOLR_PORT` to a plain ConfigKey<Integer>, it
shouldn't be reserving ports on the machine, it's only used for config.
* The above could be a custom
`AttributeSensorAndConfigKey<PortRange,Integer>, propagating the value from
Solr to Riak, but not sure if worth the effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
