Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-97455410
  
    Failing with NPE because it is still trying to reserve the port - this is 
done regardless of the type of the config value as the key is coming from 
`getEntityType().getSensors()` which are inferred from the class fields 
(returning key `PortAttributeSensorAndConfigKey` which tries to obtain a free 
port).
    
    From the log:
    ```
    SolrServerImpl{id=xMgHHmbI}: port 8983 not available for solr.http.port
    ```
    
    I don't see how we can work around two  `PortAttributeSensorAndConfigKey` 
fighting for the same port, can't be overridden with config only. As I wrote 
above changing `SEARCH_SOLR_PORT` to a `ConfigKey<Integer>` will solve the 
problem.
    
    ---
    
    When Solr is created as a child of Riak, might be better to set 
`SoftwareProcess.CHILDREN_STARTABLE_MODE=FOREGROUND_LATE` so the two installs 
don't fight over apt-get. Looks like Riak is happy to start before there's a 
Solr port to talk to, but this might prove to be a problem as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to