Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#discussion_r32872446
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNode.java ---
@@ -118,8 +119,12 @@
PortAttributeSensorAndConfigKey EPMD_LISTENER_PORT = new
PortAttributeSensorAndConfigKey("epmdListenerPort", "Erlang Port Mapper Daemon
Listener Port", "4369");
PortAttributeSensorAndConfigKey ERLANG_PORT_RANGE_START = new
PortAttributeSensorAndConfigKey("erlangPortRangeStart", "Erlang Port Range
Start", "6000+");
PortAttributeSensorAndConfigKey ERLANG_PORT_RANGE_END = new
PortAttributeSensorAndConfigKey("erlangPortRangeEnd", "Erlang Port Range End",
"7999+");
- PortAttributeSensorAndConfigKey SEARCH_SOLR_PORT = new
PortAttributeSensorAndConfigKey("search.solr.port", "Solr port", "8093+");
- PortAttributeSensorAndConfigKey SEARCH_SOLR_JMX_PORT = new
PortAttributeSensorAndConfigKey("search.solr.jmx_port", "Solr port", "8985+");
+
+ @SetFromFlag("searchEnabled")
+ ConfigKey<Boolean> SEARCH_ENABLED =
ConfigKeys.newBooleanConfigKey("riak.search", "Deploy Solr and configure Riak
to use it", false);
+
+ ConfigKey<Integer> SEARCH_SOLR_PORT =
ConfigKeys.newIntegerConfigKey("search.solr.port", "Solr port", 8983);
--- End diff --
Why not use `PortAttributeSensorAndConfigKey`, out of interest? A
consequence of using `ConfigKey<Integer>` is that we won't auto-detect that it
is a port so won't know to open the port in AWS security groups and/or iptables
etc.
Is that deliberate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
