PengZheng commented on code in PR #710: URL: https://github.com/apache/celix/pull/710#discussion_r1445606810
########## bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi_constants.h: ########## @@ -36,6 +36,15 @@ #define RSA_DFI_CONFIGURATION_TYPE "org.amdatu.remote.admin.http" #define RSA_DFI_ENDPOINT_URL "org.amdatu.remote.admin.http.url" +/** + * @brief RSA Configuration type for zeroconf http, it is synonymous(https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteservices.html#i1698916) with RSA_DFI_CONFIGURATION_TYPE, they refer to the same endpoint. Review Comment: Here are some inconsistencies between RSA and ZEROCONF: RSA may not bind all (i.e. not bind to a specific ip address) while ZEROCONF will advertise all addresses associated with a network interface. The interface between RSA and ZEROCONF should be carefully designed to address this issue. Otherwise, there will be performance penalty, e.g. try addresses that have no binder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
