pnoltes commented on code in PR #710: URL: https://github.com/apache/celix/pull/710#discussion_r1446502101
########## bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi_constants.h: ########## @@ -36,6 +36,15 @@ #define RSA_DFI_CONFIGURATION_TYPE "org.amdatu.remote.admin.http" #define RSA_DFI_ENDPOINT_URL "org.amdatu.remote.admin.http.url" +/** + * @brief RSA Configuration type for zeroconf http, it is synonymous(https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteservices.html#i1698916) with RSA_DFI_CONFIGURATION_TYPE, they refer to the same endpoint. Review Comment: > It means that if we use zeroconf_discovery, the remote service will still work even if RSA does not configure an IP. That is a nice feature and for now I cannot think of a way to this without some coupling between the RSA and discovery. The option is what you mention is a good way to opt-in for discovery specific behaviour. Maybe more generic and not coupled to zeroconf. e.g: - If a remote endpoint has property has a property "CELIX_RSA_DISCOVERY_IP_ADRESSES" then the value will be updated to discovered ip addresses. If I look at the RSA spec (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteserviceadmin.html#org.osgi.service.remoteserviceadmin.RemoteServiceAdmin), `exportService` does allow to return multiple ExportRegistration and thus multiple endpoints. Maybe this can be combined and the RSA DFI can provide mutiple ExportRegistrations. 1 for the fixed IP and 1 for a dynamic IP adresses. I will read the spec a bit more and check whether exporting multiple ExportRegistration (with multiple paths to the same exported service) is feasible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
