xuzhenbao commented on PR #710:
URL: https://github.com/apache/celix/pull/710#issuecomment-1926084338
@pnoltes
I have updated the PR, it includes the following changes:
1.Move the work of exporting dynamic IP endpoints to the Topology Manager,
the dynamic IP endpoints contain the following specific properties.
- celix.rsa.ip.addresses
The list of dynamic IPs, the Topology Manager should set an empty
celix.rsa.ip.addresses property, and DISCOVERY will fill in the dynamic IP when
it detects the celix.rsa.ip.addresses property
- celix.rsa.port
The port number of the remote service, its value is filled by RSA
- celix.rsa.ifname
Network interface name, set by Topology Manager
2. The endpoint listener service of Discovery adds the property
celix.rsa.discovery.interface.specific.endpoints.support, which indicates
whether DISCOVERY supports dynamic IP filling based on the network interface
name.
3. The RSA service adds the property celix.rsa.dynamic.ip.support, which
indicates whether RSA supports dynamic IP. When the
celix.rsa.dynamic.ip.support property is true, the Topology Manager should
generate dynamic IP endpoints based on the registration exported by RSA, and
notify these endpoints to the DISCOVERY implementation that supports dynamic IP.
4. Add configuration property CELIX_RSA_INTERFACES_OF_PORT_<port> (e.g.
CELIX_RSA_INTERFACES_OF_PORT_8080=eth0,eth1), which indicates to which network
interfaces the server of the corresponding port should be bound. The Topology
Manager should fill in the celix.rsa.ifname property based on these
configurations when creating dynamic IP endpoints.
5. Add the Facility of libcurl error codes, which is used to distinguish
between http status code (CELIX_FACILITY_HTTP) and libcurl error codes in
`rsa_dfi`
6. Add CELIX_RSA prefix for constants in the `rsa_spi`
7. celix.rsa.ip.addresses currently uses a comma-separated string, and it
will use a string array (It depends on
https://github.com/apache/celix/issues/674)
8. Topology Manager and RSA_DFI still leave some deprecated interfaces
usage, and the related code is planned to be cleaned up in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
