xuzhenbao commented on code in PR #710: URL: https://github.com/apache/celix/pull/710#discussion_r1446170831
########## bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi_constants.h: ########## @@ -36,6 +36,15 @@ #define RSA_DFI_CONFIGURATION_TYPE "org.amdatu.remote.admin.http" #define RSA_DFI_ENDPOINT_URL "org.amdatu.remote.admin.http.url" +/** + * @brief RSA Configuration type for zeroconf http, it is synonymous(https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteservices.html#i1698916) with RSA_DFI_CONFIGURATION_TYPE, they refer to the same endpoint. Review Comment: > IMO the zeroconf discovery and remote service admins are now entangled and this is not needed. Adding the host name resolution mechanism to `zeroconf_discovery` does cause `RSA` to become entangled with `zeroconf_discovery`. The main reason for adding the host name resolution mechanism to `zeroconf_discovery` is that if `RSA` binds to any address (0.0.0.0), then it does not need to configure a specific IP, and `zeroconf_discovery` resolves IP list from the host name, then gives the IP list to the client via the " <config_type>.ipaddresses" endpoint property. It means that if we use `zeroconf_discovery`, the remote service will still work even if `RSA` does not configure an IP. For the above issue, should we do host name resolution in `zeroconf_discovery`? If we use host name in the URL of the endpoint (e.g. http://computer.local:8080/service/example) maybe that will resolve the problem as well. (Host name resolution will be done by the `RSA`) If we do host name resolution in `zeroconf_discovery`, we should design interfaces between `RSA` and `zeroconf_discovery` for distinguishing whether host name resolution is needed or not, because we don't need to do host name resolution for an endpoint that already specifies a specific IP. In my option, we can add a specific property(e.g. `<config_type>.automatically_get_ip_by_discovery`) to the endpoint description, and `zeroconf_discovery` will do host name resolution according to this property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
