PengZheng commented on code in PR #710:
URL: https://github.com/apache/celix/pull/710#discussion_r1445610109
##########
bundles/remote_services/discovery_zeroconf/src/discovery_zeroconf_announcer.c:
##########
@@ -115,38 +114,23 @@ celix_status_t
discoveryZeroconfAnnouncer_create(celix_bundle_context_t *ctx, ce
celix_autoptr(celix_thread_mutex_t) mutex = &announcer->mutex;
celix_autoptr(celix_string_hash_map_t) endpoints = announcer->endpoints =
celix_stringHashMap_create();
- assert(announcer->endpoints != NULL);
+ if (endpoints == NULL) {
+ celix_logHelper_logTssErrors(logHelper, CELIX_LOG_LEVEL_ERROR);
+ celix_logHelper_fatal(logHelper, "Announcer: Failed to create
endpoints map.");
Review Comment:
IMO, `ENOMEM` should not be fatal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
