Hi Hasan Thanks for the good work!
The dataset package seems a bit a leftover of rather messy things. I think having a DataSet interface in the main .api package would allow this package to be focused on proving a secured implementation of this interface. Cheers, Reto -----Original Message----- From: Hasan Hasan <[email protected]> Sent: Friday, February 15, 2019 9:43 PM To: [email protected]; Reto Gmür <[email protected]>; Furkan KAMACI <[email protected]> Subject: Re: Clerezza refactoring Hi all @Reto Gmür <[email protected]> Please checkout the reunited branch and check whether I miss something. I haven't implemented the idea as discussed in the start of this thread. But the reunited branch can be a good basis for that. @Furkan KAMACI <[email protected]>, I have resolved CLEREZZA-1036 Kind regards Hasan On Mon, Feb 11, 2019 at 7:44 AM Hasan Hasan <[email protected]> wrote: > Hi Furkan > > Have you tried to check the branch? If you have questions, please > don't hesitate to ask. > Maybe you can try to solve CLEREZZA-1036. > > Cheers > Hasan > > On Mon, Jan 28, 2019 at 5:56 PM Furkan KAMACI <[email protected]> > wrote: > >> Hi Hasan, >> >> I'll check the branch and help to refactoring! >> >> Kind Regards, >> Furkan KAMACI >> >> On Fri, Jan 25, 2019 at 10:16 AM Hasan Hasan <[email protected]> >> wrote: >> >>> Dear all >>> >>> Within this refactoring effort, I'll move the package >>> org.apache.clerezza.rdf.core.access >>> from module rdf to a new module. >>> I have some candidate names for the new module: >>> - dataset >>> - graph >>> - graph.management >>> - triplecollection.management >>> >>> Name suggestions and comments are welcome, if any. >>> >>> Note that the module rdf will be removed once it is completely >>> refactored. >>> >>> Cheers >>> Hasan >>> >>> On Fri, Jan 25, 2019 at 6:34 AM Hasan <[email protected]> wrote: >>> >>>> Hi Reto >>>> >>>> Thanks for the information. >>>> I'll take a look this weekend. >>>> >>>> Hasan >>>> >>>> On Wed, Jan 23, 2019 at 9:29 PM Reto Gmür <[email protected]> >>>> wrote: >>>> >>>>> Hi Hasan >>>>> >>>>> I had troubles compiling this branch as the relativePath of the >>>>> parent was mostly not set. I think if we set it, the whole reactor >>>>> can be built, but it becomes harder to make partial releases. An >>>>> approach is to have all modules depend on the latests released version of >>>>> the parent. >>>>> >>>>> Cheers, >>>>> Reto >>>>> >>>>> -----Original Message----- >>>>> From: Hasan Hasan <[email protected]> >>>>> Sent: Monday, January 21, 2019 8:03 AM >>>>> To: [email protected]; Furkan KAMACI >>>>> <[email protected]> >>>>> Subject: Re: Clerezza refactoring >>>>> >>>>> Dear all >>>>> >>>>> I'd like to continue working on the refactoring with the help of >>>>> Furkan Kamaci. >>>>> @Furkan KAMACI <[email protected]>: could you please take a >>>>> look at the reunited branch and let's discuss how to proceed step >>>>> by step to make clerezza better. >>>>> >>>>> Cheers >>>>> Hasan >>>>> >>>>> >>>>> On Fri, Mar 9, 2018 at 4:29 PM Reto Gmür <[email protected]> wrote: >>>>> >>>>> > Hi Hasan >>>>> > >>>>> > I'm not sure how usefull this is, and if PDFs make it to the list. >>>>> > >>>>> > Cheers, >>>>> > Reto >>>>> > >>>>> > > -----Original Message----- >>>>> > > From: Hasan <[email protected]> >>>>> > > Sent: Tuesday, February 27, 2018 8:02 AM >>>>> > > To: [email protected] >>>>> > > Subject: Re: Clerezza refactoring >>>>> > > >>>>> > > I don't have much time if you can bear with me.... >>>>> > > >>>>> > > I would say yes, we'll use the reunited branch as the new master. >>>>> > > Could you please send me the notes about the changes we discussed. >>>>> > > Or perhaps a summary of it? I seem to not have it anymore. >>>>> > > Sorry >>>>> Reto. >>>>> > > >>>>> > > Hasan >>>>> > > >>>>> > > On Mon, Feb 26, 2018 at 12:50 PM, Reto Gmür <[email protected]> >>>>> wrote: >>>>> > > >>>>> > > > Hi Hasan >>>>> > > > >>>>> > > > Will you be performing the drafted changes? Vscode that I'm >>>>> using >>>>> > > > now is not so good at refactoring, so I would appreciate you >>>>> doing it. >>>>> > > > >>>>> > > > Do we take the reunited branch as new master (and drop the >>>>> > > > rdf-commons repo)? >>>>> > > > >>>>> > > > Cheers, >>>>> > > > Reto >>>>> > > > >>>>> > > > > -----Original Message----- >>>>> > > > > From: Hasan Hasan [mailto:[email protected]] >>>>> > > > > Sent: Sunday, February 18, 2018 6:42 PM >>>>> > > > > To: [email protected] >>>>> > > > > Subject: Re: Clerezza refactoring >>>>> > > > > >>>>> > > > > Hi Reto >>>>> > > > > >>>>> > > > > On Sun, Feb 11, 2018 at 5:51 PM, Reto Gmür >>>>> > > > > <[email protected]> >>>>> wrote: >>>>> > > > > >>>>> > > > > > Hi Hasan >>>>> > > > > > >>>>> > > > > > The second argument would the graph to be added, or the >>>>> > > > > > initial content to be added to that named graph. >>>>> > > > > > >>>>> > > > > >>>>> > > > > ah yes, of course. >>>>> > > > > >>>>> > > > > thx >>>>> > > > > hasan >>>>> > > > > >>>>> > > > > > >>>>> > > > > > >>>>> > > > > > Cheers, >>>>> > > > > > Reto >>>>> > > > > > > -----Original Message----- >>>>> > > > > > > From: Hasan [mailto:[email protected]] >>>>> > > > > > > Sent: Thursday, February 1, 2018 10:25 PM >>>>> > > > > > > To: [email protected] >>>>> > > > > > > Subject: Re: Clerezza refactoring >>>>> > > > > > > >>>>> > > > > > > Hi Reto >>>>> > > > > > > >>>>> > > > > > > Yes, that would be nice. >>>>> > > > > > > But why we need a second argument in addNamedGraph ? >>>>> > > > > > > >>>>> > > > > > > hasan >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > On Thu, Feb 1, 2018 at 8:25 PM, Tommaso Teofili >>>>> > > > > > > <[email protected]> >>>>> > > > > > > wrote: >>>>> > > > > > > >>>>> > > > > > > > +1 >>>>> > > > > > > > >>>>> > > > > > > > Tommaso >>>>> > > > > > > > >>>>> > > > > > > > 2018-01-27 18:03 GMT+01:00 Reto Gmür <[email protected]>: >>>>> > > > > > > > >>>>> > > > > > > > > Hi Hasan, >>>>> > > > > > > > > >>>>> > > > > > > > > Thanks for the good conversation today. >>>>> > > > > > > > > >>>>> > > > > > > > > I was thinking on how the discussed replacement of >>>>> > > > > > > > > TcManager with DataSet could look like. I think it >>>>> would >>>>> > > > > > > > > be nice for code like this >>>>> > > > > > to work: >>>>> > > > > > > > > >>>>> > > > > > > > > Graph g = new SimpleGraph(); >>>>> > > > > > > > > g.addTriple(s, p, o); //new shortcut >>>>> > > > > > > > > method >>>>> for >>>>> > > > > > > > > add(new TripleImpl(s,p,o)); >>>>> > > > > > > > > BlankNodeOrIRI graphName = new IRI(" >>>>> > > > http://example.org/g2";); >>>>> > > > > > > > > DataSet ds = new >>>>> DataSetBuilder().setDefaultGraph(g). >>>>> > > > > > > > addNamedGraph(graphName, >>>>> > > > > > > > > g2).build(); >>>>> > > > > > > > > ResultSet rs = ds.querySelect("SELECT >>>>> > > > > > > > > ...."); >>>>> > > > > > > > > >>>>> > > > > > > > > I'm looking forward to a simplified and documented >>>>> clerezza. >>>>> > > > > > > > > >>>>> > > > > > > > > Cheers, >>>>> > > > > > > > > Reto >>>>> > > > > > > > > >>>>> > > > > > > > > >>>>> > > > > > > > > >>>>> > > > > > > > >>>>> > > > > > >>>>> > > > > > >>>>> > > > >>>>> > > > >>>>> > >>>>> >>>>
