imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318595755
##########
File path: be/src/olap/data_dir.cpp
##########
@@ -582,7 +576,9 @@ OLAPStatus DataDir::_convert_old_tablet() {
for (auto& rowset_pb : pending_rowsets) {
string meta_binary;
rowset_pb.SerializeToString(&meta_binary);
- status = RowsetMetaManager::save(_meta, rowset_pb.tablet_uid(),
rowset_pb.rowset_id() , meta_binary);
+ RowsetId rowset_id;
+ rowset_id.init(rowset_pb.rowset_id_v2());
Review comment:
if this is old version rwset_pb, this field will be 0. Is there no problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
