imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318593211
##########
File path: be/src/olap/rowset/rowset_meta_manager.h
##########
@@ -31,20 +31,20 @@ namespace doris {
// Helper class for managing rowset meta of one root path.
class RowsetMetaManager {
public:
- static bool check_rowset_meta(OlapMeta* meta, TabletUid tablet_uid,
int64_t rowset_id);
+ static bool check_rowset_meta(OlapMeta* meta, TabletUid tablet_uid,
RowsetId rowset_id);
Review comment:
```suggestion
static bool check_rowset_meta(OlapMeta* meta, TabletUid tablet_uid,
const RowsetId& rowset_id);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
