imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r319825362
##########
File path: be/src/olap/rowset/segment_group.h
##########
@@ -262,12 +262,12 @@ class SegmentGroup {
OLAPStatus copy_files_to(const std::string& dir);
- OLAPStatus link_segments_to_path(const std::string& dest_path, int64_t
rowset_id);
+ OLAPStatus link_segments_to_path(const std::string& dest_path, RowsetId
rowset_id);
Review comment:
```suggestion
OLAPStatus link_segments_to_path(const std::string& dest_path, const
RowsetId& rowset_id);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
