-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34541/
-----------------------------------------------------------

(Updated May 21, 2015, 7:34 p.m.)


Review request for drill, Chris Westin and Jacques Nadeau.


Changes
-------

reverted back the changes to FragmentContext. We don't actually need to check 
if the sender is "ignored", now that the rpc layer don't hold references to the 
buffer, the fragment will properly handle the buffer


Bugs: DRILL-3147
    https://issues.apache.org/jira/browse/DRILL-3147


Repository: drill-git


Description (updated)
-------

- BaseRawBatchBuffer methods enqueue() and kill() are now synchronized
- TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because it 
requires a large dataset


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java 
80d2d6e 
  
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java
 11b6cc8 
  
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java
 b770a33 
  
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/34541/diff/


Testing (updated)
-------

still need to run the tests!


Thanks,

abdelhakim deneche

Reply via email to