> On May 21, 2015, 8:18 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java, > > line 65 > > <https://reviews.apache.org/r/34541/diff/3/?file=966937#file966937line65> > > > > There is no need for this to be synchronized. What is you reason for > > making this change? > > > > All access to this method happens through a single thread.
If I'm not mistaken, DataServer.send() will pass a buffer to BaseRawBatchBuffer.enqueue() through FragmentManager.handle(), and BaseRawBatchBuffer.kill() will be called from the FragmentExecutor's thread. Those are different threads right ? - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34541/#review84779 ----------------------------------------------------------- On May 21, 2015, 7:34 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34541/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 7:34 p.m.) > > > Review request for drill, Chris Westin and Jacques Nadeau. > > > Bugs: DRILL-3147 > https://issues.apache.org/jira/browse/DRILL-3147 > > > Repository: drill-git > > > Description > ------- > > - BaseRawBatchBuffer methods enqueue() and kill() are now synchronized > - TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because > it requires a large dataset > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java > 80d2d6e > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java > 11b6cc8 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java > b770a33 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34541/diff/ > > > Testing > ------- > > still need to run the tests! > > > Thanks, > > abdelhakim deneche > >
