> On May 26, 2015, 6:41 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java, > > line 53 > > <https://reviews.apache.org/r/34541/diff/4/?file=970092#file970092line53> > > > > Do we require a @AfterClass method to change the cluster size back to > > initial? Or does that not matter?
BaseTestQuery.resetDrillbitCount() is an @AfterClass method that takes care of it > On May 26, 2015, 6:41 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java, > > line 62 > > <https://reviews.apache.org/r/34541/diff/4/?file=970092#file970092line62> > > > > The test framework already prints out the name of the test. Is this > > addtional print necessary? the name will only be displayed once. Printing the iteration # gives a sense of progresssion, especially when repeating the test 1000 times - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34541/#review85209 ----------------------------------------------------------- On May 22, 2015, 11:15 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34541/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 11:15 p.m.) > > > Review request for drill, Chris Westin and Jacques Nadeau. > > > Bugs: DRILL-3147 > https://issues.apache.org/jira/browse/DRILL-3147 > > > Repository: drill-git > > > Description > ------- > > - BaseRawBatchBuffer methods enqueue() and kill() are now synchronized > - TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because > it requires a large dataset > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java > 80d2d6e > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java > 11b6cc8 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java > b770a33 > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java a07f621 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java > PRE-CREATION > exec/java-exec/src/test/resources/tpcds-sf1/q73.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/34541/diff/ > > > Testing > ------- > > still need to run the tests! > > > Thanks, > > abdelhakim deneche > >
