> On May 21, 2015, 5:08 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java, > > line 417 > > <https://reviews.apache.org/r/34541/diff/2/?file=966656#file966656line417> > > > > Is there an alternative implementation? I feel like this method should > > not be part of FragmentContext.
we don't need this change anymore. > On May 21, 2015, 5:08 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java, > > line 68 > > <https://reviews.apache.org/r/34541/diff/2/?file=966661#file966661line68> > > > > Unnecessary "synchronized"? This was done as part of my trials to fix this leak. I will probably revert it back - abdelhakim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34541/#review84727 ----------------------------------------------------------- On May 21, 2015, 7:34 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34541/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 7:34 p.m.) > > > Review request for drill, Chris Westin and Jacques Nadeau. > > > Bugs: DRILL-3147 > https://issues.apache.org/jira/browse/DRILL-3147 > > > Repository: drill-git > > > Description > ------- > > - BaseRawBatchBuffer methods enqueue() and kill() are now synchronized > - TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because > it requires a large dataset > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java > 80d2d6e > > exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java > 11b6cc8 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java > b770a33 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34541/diff/ > > > Testing > ------- > > still need to run the tests! > > > Thanks, > > abdelhakim deneche > >
