> On May 22, 2015, 6:15 p.m., Chris Westin wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java,
> > line 56
> > <https://reviews.apache.org/r/34541/diff/3/?file=966939#file966939line56>
> >
> > Can we indent this a little better so it's easier to see the nested
> > select separately from the rest of the query, as well as the order by and
> > group by clauses? It might help to condense the select lists onto a single
> > line. For example
> >
> > select .....,
> > more columns, if necessary
> > from ...
> > more of that, if necessary
> > where ...
> > group by ...
> > order by ...
> > limit ...
You could put the query in a file and use BaseTestQuery.getFile(...)
For example:
```
final String query = BaseTestQuery.getFile("queries/tpch/09.sql");
```
- Sudheesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34541/#review84943
-----------------------------------------------------------
On May 21, 2015, 7:34 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34541/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 7:34 p.m.)
>
>
> Review request for drill, Chris Westin and Jacques Nadeau.
>
>
> Bugs: DRILL-3147
> https://issues.apache.org/jira/browse/DRILL-3147
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - BaseRawBatchBuffer methods enqueue() and kill() are now synchronized
> - TestTpcdsSf1Leak test reproduces the leak, it's ignored by default because
> it requires a large dataset
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java
> 80d2d6e
>
> exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/BaseRawBatchBuffer.java
> 11b6cc8
>
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java
> b770a33
>
> exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34541/diff/
>
>
> Testing
> -------
>
> still need to run the tests!
>
>
> Thanks,
>
> abdelhakim deneche
>
>
