paul-rogers commented on a change in pull request #1652: DRILL-7046: Support
for loading and parsing new RM config file
URL: https://github.com/apache/drill/pull/1652#discussion_r259595730
##########
File path:
common/src/main/java/org/apache/drill/common/config/CommonConstants.java
##########
@@ -17,21 +17,33 @@
*/
package org.apache.drill.common.config;
-public interface CommonConstants {
+public final class CommonConstants {
Review comment:
Just curious, any reason to make this a class rather than an interface? I
don't see any methods...
The name "CommonConstants" suggests a kitchen-sink kind of thing. I wonder,
should this be called "ConfigConstants" to more clearly state its purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
