paul-rogers commented on a change in pull request #1652: DRILL-7046: Support for loading and parsing new RM config file URL: https://github.com/apache/drill/pull/1652#discussion_r259595892
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/QueryQueueConfigImpl.java ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.resourcemgr; + +import com.typesafe.config.Config; +import org.apache.drill.exec.resourcemgr.exception.RMConfigException; + +import java.util.UUID; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import static org.apache.drill.exec.resourcemgr.RMCommonDefaults.MAX_ADMISSIBLE_DEFAULT; +import static org.apache.drill.exec.resourcemgr.RMCommonDefaults.MAX_WAITING_DEFAULT; + +/** + * Parses and initialize QueueConfiguration for a {@link ResourcePool}. It also generates a unique UUID for each queue + * which will be later used by Drillbit to store in Zookeeper along with + * {@link org.apache.drill.exec.proto.beans.DrillbitEndpoint}. This UUID is used in the leader election mechanism in + * which Drillbit participates for each of the configured rm queue. + */ +public class QueryQueueConfigImpl implements QueryQueueConfig { + + private String queueUUID; Review comment: final? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
