paul-rogers commented on a change in pull request #1652: DRILL-7046: Support
for loading and parsing new RM config file
URL: https://github.com/apache/drill/pull/1652#discussion_r259595744
##########
File path:
common/src/main/java/org/apache/drill/common/config/CommonConstants.java
##########
@@ -17,21 +17,33 @@
*/
package org.apache.drill.common.config;
-public interface CommonConstants {
+public final class CommonConstants {
/** Default (base) configuration file name. (Classpath resource pathname.)
*/
- String CONFIG_DEFAULT_RESOURCE_PATHNAME = "drill-default.conf";
+ public static final String CONFIG_DEFAULT_RESOURCE_PATHNAME =
"drill-default.conf";
/** Module configuration files name. (Classpath resource pathname.) */
- String DRILL_JAR_MARKER_FILE_RESOURCE_PATHNAME = "drill-module.conf";
+ public static final String DRILL_JAR_MARKER_FILE_RESOURCE_PATHNAME =
"drill-module.conf";
/** Distribution Specific Override configuration file name. (Classpath
resource pathname.) */
- String CONFIG_DISTRIBUTION_RESOURCE_PATHNAME = "drill-distrib.conf";
+ public static final String CONFIG_DISTRIBUTION_RESOURCE_PATHNAME =
"drill-distrib.conf";
/** Override configuration file name. (Classpath resource pathname.) */
- String CONFIG_OVERRIDE_RESOURCE_PATHNAME = "drill-override.conf";
+ public static final String CONFIG_OVERRIDE_RESOURCE_PATHNAME =
"drill-override.conf";
/** Override plugins configs file name. (Classpath resource pathname.) */
- String STORAGE_PLUGINS_OVERRIDE_CONF = "storage-plugins-override.conf";
+ public static final String STORAGE_PLUGINS_OVERRIDE_CONF =
"storage-plugins-override.conf";
+ /** Default RM configuration file name. (Classpath resource pathname.) */
+ public static final String RM_CONFIG_DEFAULT_RESOURCE_PATHNAME =
"drill-rm-default.conf";
+
+ /** Distribution Specific RM Override configuration file name. (Classpath
resource pathname.) */
+ public static final String RM_CONFIG_DISTRIBUTION_RESOURCE_PATHNAME =
"drill-rm-distrib.conf";
+
+ /** RM Override configuration file name. (Classpath resource pathname.) */
+ public static final String RM_CONFIG_OVERRIDE_RESOURCE_PATHNAME =
"drill-rm-override.conf";
Review comment:
Very glad to see we're using the HOCON system for RM config. No reason to
reinvent that system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
