paul-rogers commented on a change in pull request #1652: DRILL-7046: Support for loading and parsing new RM config file URL: https://github.com/apache/drill/pull/1652#discussion_r259595961
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/QueryQueueConfig.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.resourcemgr; + +/** + * Interface which defines an implementation for managing queue configuration of a {@link ResourcePool} + */ +public interface QueryQueueConfig { + String getQueueId(); + + String getQueueName(); + + long getQueueTotalMemoryInMB(int numClusterNodes); + + long getMaxQueryMemoryInMBPerNode(); + + long getMaxQueryTotalMemoryInMB(int numClusterNodes); + + boolean waitForPreferredNodes(); Review comment: Great idea to have an interface. Would be great to add a comment to each method where the meaning is not clear, such as this one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
