paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314789387
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java
##########
@@ -17,24 +17,26 @@
*/
package org.apache.drill.test;
+import java.io.OutputStreamWriter;
import java.util.Iterator;
import org.apache.drill.exec.exception.SchemaChangeException;
import org.apache.drill.exec.memory.BufferAllocator;
+import org.apache.drill.exec.physical.rowSet.RowSetStringBuilder;
import org.apache.drill.exec.proto.UserBitShared.QueryId;
import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState;
import org.apache.drill.exec.proto.helper.QueryIdHelper;
import org.apache.drill.exec.record.RecordBatchLoader;
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.rpc.user.QueryDataBatch;
import org.apache.drill.test.BufferingQueryEventListener.QueryEvent;
-import org.apache.drill.test.rowSet.DirectRowSet;
+import org.apache.drill.exec.physical.rowSet.DirectRowSet;
public class QueryRowSetIterator implements Iterator<DirectRowSet>,
Iterable<DirectRowSet> {
private final BufferingQueryEventListener listener;
private int recordCount = 0;
private int batchCount = 0;
- QueryId queryId = null;
+ private QueryId queryId = null;
Review comment:
As long as you are touching this code, please remove the do-nothing
initializers:
```
private int recordCount;
private int batchCount;
private QueryId queryId;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
