paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314816402
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetWriterImpl.java
##########
@@ -129,7 +129,7 @@ public RowSetWriter addRow(Object...values) {
@Override
public RowSetWriter addSingleCol(Object value) {
- return addRow(new Object[] {value});
+ return addRow(value);
Review comment:
Ah! But I don't want to do the cast; that is the purpose of this method. I
want:
```
...addRow(mapValue(10, "foo"), 20); // convenience
...addRow(new Object[] {10, "foo"}, 20); // low-level
...
...addSingleCol(mapValue(10, "foo"); // convenience
... addSingleCol(new Object[] {10, "foo"}); // low-level
```
Unless we wrap that single column in another array, the second form is the
same as:
```
... addRow(new Object[] {10, "foo"});
```
Which will be interpreted as a set of two columns, not as a single column
with a map-value.
I could be wrong, and I'd have to test actual code to be sure. In fact, I'll
do that test this weekend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
