paul-rogers commented on a change in pull request #1843: DRILL-7350: Move 
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314787032
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/store/log/TestLogReader.java
 ##########
 @@ -781,9 +781,19 @@ public void testPluginSerialization() throws IOException {
 
   @Test
   public void testFirewallSchema() throws RpcException {
-    String sql = "SELECT * FROM cp.`regex/firewall.ssdlog`";
+    String sql = "SELECT * FROM cp.`regex/firewall.ssdlog` limit 0";
     RowSet result = client.queryBuilder().sql(sql).rowSet();
-    result.print();
+    TupleMetadata expectedSchema = new SchemaBuilder()
+        .add("eventDate", TypeProtos.MinorType.TIMESTAMP, 
TypeProtos.DataMode.OPTIONAL)
 
 Review comment:
   Simpler: `addNullable("eventDate", MinorType.TIMESTAMP)`
   
   Import `MinorType`, use the `addNullable` method rather than the more 
verbose form of using the `DataMode`. That is, express intent, not 
implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to