paul-rogers commented on a change in pull request #1843: DRILL-7350: Move 
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314787920
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java
 ##########
 @@ -101,7 +103,7 @@ public DirectRowSet next() {
 
   public void printAll() {
     for (DirectRowSet rowSet : this) {
-      rowSet.print();
+      new RowSetStringBuilder(rowSet).writeTo(new 
OutputStreamWriter(System.out));
 
 Review comment:
   This is *not* a simplification; it exposes too much detail. Better:
   
   ```
   RowSetFormatter.print(rowSet);
   ```
   
   Of course, if we go this route, we might as well leave the `print()` method 
in `RowSet` and have it call the above code.
   
   Just to be clear, the purpose of `print()` is to help us developers 
visualize what's going on in Drill; it is not for production use. This is 
important because, if you can't visualize a batch, you'll make many mistakes 
because you can't tell what's what.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to